[python-nextgen] Add type to actual instance #16204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ふぁ <[email protected]>
Signed-off-by: ふぁ <[email protected]>
fa0311
changed the title
Signed-off-by: ふぁ <[email protected]>
Signed-off-by: ふぁ <[email protected]>
Member
|
Thanks for the enhancement. Looks good to me. |
wing328
reviewed
Jul 29, 2023
| if TYPE_CHECKING: | ||
| actual_instance: Union[{{#anyOf}}{{{.}}}{{^-last}}, {{/-last}}{{/anyOf}}] | ||
| else: | ||
| actual_instance: Any |
Member
There was a problem hiding this comment.
@fa0311 thank again for the PR. Just a second thought, shall we simply use the following without TYPE_CHECKING:
actual_instance: Union[{{#anyOf}}{{{.}}}{{^-last}}, {{/-last}}{{/anyOf}}]
Contributor
Author
There was a problem hiding this comment.
If TYPE_CHECKING is not used, an incorrect type conversion will be performed by pydantic.
openapi: 3.0.3
info:
title: Swagger Petstore
version: 1.0.0
paths:
/foo:
get:
responses:
default:
description: response
content:
application/json:
schema:
$ref: "#/components/schemas/Animal"
components:
schemas:
Animal:
oneOf:
- $ref: "#/components/schemas/Cat"
- $ref: "#/components/schemas/Dog"
discriminator:
propertyName: type
mapping":
Cat: "#/components/schemas/Cat"
Dog: "#/components/schemas/Dog"
Cat:
properties:
type:
type: string
color:
type: string
Dog:
properties:
type:
type: string
bark:
type: stringinputSpec: test.yaml
outputDir: .
packageName: petstore
projectName: petstore
useOneOfDiscriminatorLookup: truefrom petstore import Animal
res = Animal.from_dict({"type": "Dog", "bark": "loud"})
print(type(res.actual_instance)) # <class 'petstore.models.cat.Cat'>In this example, the type is Dog, but the actual_instance is <class 'petstore.models.cat.Cat'>.
Assumed type of actual_instance is <class 'petstore.models.dog.Dog'>
If there is another, even better way to work around this, we will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)Overview
This is a small update.
Add type hints.